Skip to content

Conversation

@markdumay
Copy link
Contributor

@markdumay markdumay commented Dec 26, 2022

Description

The file scss/_variables.scss defines several embedded svg images. The svg definitions use parameterization to support Bootstrap's color system. The declaration of $navbar-light-toggler-icon-bg is inconsistent with the other declarations, as it uses #{rgba($body-color, .75)} instead of referring to a predefined variable.

Motivation & Context

This PR introduces a new variable $navbar-light-icon-color to improve consistency. The existing variable $navbar-light-color is kept intact to avoid introducing unwanted side effects.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

N/A

@markdumay markdumay requested a review from a team as a code owner December 26, 2022 06:01
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had done the separate fill on purpose, but I’m fine having a variable for it. Thanks!

@XhmikosR XhmikosR merged commit 98ebf3a into twbs:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants