CodeQL: ignore dist folder #37486
Merged
CodeQL: ignore dist folder #37486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
reviewed
Nov 13, 2022
| @@ -0,0 +1,3 @@ | |||
| name: "CodeQL config" | |||
| paths-ignore: | |||
Member
There was a problem hiding this comment.
is it ok for now to keep this options inside the same job?
Member
Author
There was a problem hiding this comment.
What do you mean? If you mean not a separate file, I don't think that's possible.
Member
There was a problem hiding this comment.
Found this too.
https://github.blog/changelog/2022-08-31-code-scanning-customize-your-codeql-analysis-using-query-filters/
Anyway, it seems fine to go
Member
Author
There was a problem hiding this comment.
Yeah, that link shows that it's not possible to exclude files/folders without a config file.
GeoSot
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It probably makes sense since these are build files.
That being said, it might also make sense to add CodeQL to popper.js if they don't have it already. If someone could make an upstream PR that would be perfect :)