Home imports #37318
Merged
Home imports #37318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
Few comments for this PR but the overall is good. Like the new architecture and the small improvements that make the difference.
Member
Author
|
Great feedback all around! Just pushed up some changes to address everything here. |
Member
julien-deramond
left a comment
julien-deramond
left a comment
There was a problem hiding this comment.
My last 2 comments regarding this PR and I think we're good to go 🚀
This comment was marked as off-topic.
This comment was marked as off-topic.
Also modifies the homepage code snippets under getting started to remove the code comments, making copy-pasting easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks up the homepage's
masthead-followup.htmlpartial into more manageable pieces. Made some copy changes alongside it. Fair warning, this might need another pass from me yet—I did this a couple weeks ago and forgot to push the branch until now.