Fix modal event-listeners during dismiss click

[GeoSot]

Partially regression of #36401.

Fixes modal listeners in order to:

• ignore clicks on scrollbar
  • mousedown, mouseup listen to scrollbar click
  • click ignores scrollbar click
• ignores clicks that starts inside .modal-dialog, but ends outside of it
• react on clicks that start & end outside .modal-dialog

closes: #36855

alternative approach #36855 (comment)

[mdo]

Is this good to merge @GeoSot or do you need a review from someone?

[GeoSot]

I would appreciate a review just to be sure

[julien-deramond]

I prefer this one compared to the alternative approach.

Tested the whole Modals page on macOS with different browsers (Firefox, Chrome, Edge and Safari) and couldn't spot any regressions.

LGTM! 🚀

[neoteknic]

@GeoSot Any 5.2.2 release ? Can you disable 5.2.1 because it broke many projets. Have to force 5.2.0 for now.

[folknor]

@GeoSot Any 5.2.2 release ? Can you disable 5.2.1 because it broke many projets. Have to force 5.2.0 for now.

Yes, please do a 5.2.2 soon. Thank you!

[GeoSot]

I can understand you on this. I personally, have done a lot of refactoring to bring our codebase to a better condition, preparing it for v6, and unfortunately sometimes mistakes can be done. I apologize for this.
Furthermore, as a team, we are trying our best, working on our free time, so please make some patience and we will try to have a release soon

[XhmikosR]

I will release 5.2.2 tomorrow or Monday. Please be patient.

…

On Sat, Oct 1, 2022, 19:58 GeoSot ***@***.***> wrote: I can understand you on this. I personally, have done a lot of refactoring to bring our codebase to a better condition, preparing it for v6, and unfortunately sometimes mistakes can be done. I apologize for this. Furthermore, as a team, we are trying our best, working on our free time, so please make some patience and we will try to have a release soon — Reply to this email directly, view it on GitHub <#36863 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNOTTBSVQK2ZRGD3XRDWBBUUNANCNFSM55CIOTHA> . You are receiving this because your review was requested.Message ID: ***@***.***>