Add some details on "javascript" page #36363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Good idea to group and isolate jQuery stuff at the end! I find the content of this page clearer.
Sorry I've only seen that this PR was a draft at the end after having already created some comments. I still leave them here if they can be useful.
As you know I'm not a native speaker so take my feedback with caution 😄
GeoSot
force-pushed
the
gs/js-docs
branch
3 times, most recently
from
1ff4449 to
a194612
Compare
- Shorten copy here and there - Reduce some callouts that are entire sections with h2 headings - Re-arrange a couple things
Member
|
Pushed a big copy update after walking through this. Appreciate the polish! |
mdo
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to help newcomers, adding some information on "getting-started => javascript"
Changes:
data-bs-config)getInstance&getOrCreateInstancemethodsdisposemethodNeeds:
Preview : https://deploy-preview-36363--twbs-bootstrap.netlify.app/docs/5.2/getting-started/javascript/