Skip to content

Convert dropdowns to CSS variables #35409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdo merged 1 commit into from
Feb 15, 2022
Merged

Convert dropdowns to CSS variables #35409

mdo merged 1 commit into from
Feb 15, 2022

Conversation

@mdo
Copy link
Member

@mdo mdo commented Nov 28, 2021

No description provided.

@mdo mdo mentioned this pull request Nov 28, 2021
Closed
41 tasks
@dgrammatiko dgrammatiko mentioned this pull request Jan 27, 2022
Closed
@mdo mdo marked this pull request as ready for review February 11, 2022 03:56
@mdo mdo requested a review from a team as a code owner February 11, 2022 03:56
@mdo mdo force-pushed the css-vars-dropdowns branch from 8a425aa to 145dbb0 Compare February 11, 2022 03:56
ffoodd
ffoodd approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from paddings becoming shorthand (mentioned in buttons PR), everything looks fine 🙂

@ffoodd
Copy link
Member

ffoodd commented Feb 14, 2022 •
edited
Loading

Cannot check further on my phone but colored dropdowns in cheatsheets are backgroundless when opened.

This is not the case on main, I'm not sure what interferes here.

@mdo
Copy link
Member Author

mdo commented Feb 14, 2022

Cannot check further on my phone but colored dropdowns in cheatsheets are backgroundless when opened.

This is not the case on main, I'm not sure what interferes here.

Ah, that's because the variables aren't being defined as there's no .dropdown. I'll need to move the variables to .dropdown-menu most likely.

@mdo mdo force-pushed the css-vars-dropdowns branch 2 times, most recently from d776d17 to 5bdf7ff Compare February 15, 2022 01:05
@mdo mdo force-pushed the css-vars-dropdowns branch from 5bdf7ff to d5061b0 Compare February 15, 2022 03:01
@mdo mdo merged commit d568e02 into main Feb 15, 2022
@mdo mdo deleted the css-vars-dropdowns branch February 15, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees

No one assigned

Labels

css release-highlight v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdo @ffoodd