Skip to content

Conversation

@mdo
Copy link
Member

@mdo mdo commented Nov 26, 2021

No description provided.

@mdo mdo requested a review from a team as a code owner November 26, 2021 02:13
@mdo mdo mentioned this pull request Nov 28, 2021
41 tasks
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--bs-badge-bg should be used indeed, but apart from that it looks good 👌

@ffoodd
Copy link
Member

ffoodd commented Dec 21, 2021

Regarding background, I wonder if we shouldn't reintroduce colors in badges, using CSS vars to only hydrate color and background-color (as we do in alerts already). That'd fix #34016 (which is requested several times already) without introducing any BC since existing usages based on utilities would still apply.

If not (or not yet) we may simply drop the useless CSS var and merge it almost as-is.

Any thought, @XhmikosR?

I just noticed a doc sentence to change regarding .bg-light and dark text: it also applies to warning and info theme colors. I'll take care of this when possible.

@mdo
Copy link
Member Author

mdo commented Feb 11, 2022

Tried getting the browserstack (push) to pass a few times, so giving up and merging anyway :).

@mdo mdo merged commit a794219 into main Feb 11, 2022
@mdo mdo deleted the css-vars-badge branch February 11, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants