-
-
Notifications
You must be signed in to change notification settings - Fork 79.2k
Extract Component config functionality to a separate class #33872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8007f0f to
5a45eff
Compare
4b05ec8 to
7afb15f
Compare
|
@twbs/js-review After some discussion I have concluded to the following.
The third option seems to be more strict (and with some difficulties on its implementation) Any opinions are welcome |
|
So choosing the first option seems good, but the APIs should be kept private initially IMO. Since that's the fully internal thing. |
f100a38 to
63ea869
Compare
63ea869 to
2ee0975
Compare
dc0142b to
e583876
Compare
e583876 to
f08312e
Compare
2c79c96 to
07bec70
Compare
41e34b9 to
e7fe92f
Compare
e7fe92f to
0edddc9
Compare
0edddc9 to
397a9ee
Compare
fd75b76 to
00fed52
Compare
6809fd3 to
839e89f
Compare
2f47950 to
c4e5c44
Compare
74114d5 to
8859470
Compare
8859470 to
fa12080
Compare
As we use the config functionality in many places, we maybe can use it extending a base Config Class