Repository navigation
Make carousel indicators actual buttons (backport to v4) - #33166
Closed
patrickhlauke wants to merge 2 commits into
Closed
patrickhlauke wants to merge 2 commits into
patrickhlauke wants to merge 2 commits into
Conversation
patrickhlauke
force-pushed
the
patrickhlauke-carousel-indicators-v4
branch
6 times, most recently
from
February 21, 2021 03:20
895a256 to
b9df8ff
Compare
XhmikosR
reviewed
Feb 21, 2021
mdo
approved these changes
Mar 11, 2021
Member
|
Need another approval just in case @rohit2sharma95. |
rohit2sharma95
approved these changes
Mar 11, 2021
XhmikosR
marked this pull request as draft
March 11, 2021 06:48
XhmikosR
force-pushed
the
patrickhlauke-carousel-indicators-v4
branch
from
March 11, 2021 06:48
2975ddc to
dccbc35
Compare
Member
|
I marked it as draft; I'm not 100% sure about the CSS changes and specificity since people might override the selectors. |
patrickhlauke
marked this pull request as ready for review
April 11, 2021 10:26
Member
Author
|
Setting this to ready for review, but worth deciding if we're going ahead with this backport or scrapping it. |
Make carousel indicators actual buttons
XhmikosR
force-pushed
the
patrickhlauke-carousel-indicators-v4
branch
from
October 8, 2021 15:09
ee12e9b to
759bc24
Compare
Member
Author
Member
|
Revisiting this, I think we will have to skip it for the breaking changes in those selectors. So sorry for the wasted effort so long ago! 😓 |
Member
Author
|
no worries, 5 is where it's at now anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #32661