Repository navigation
Offcanvas example: transition the transform - #28203
Merged
Merged
Conversation
XhmikosR
force-pushed
the
v4-dev-xmr-offcanvas
branch
from
February 8, 2019 08:47
b1322f9 to
3d3eacd
Compare
MartijnCuppens
approved these changes
Feb 8, 2019
Member
Author
|
Not sure about removing |
Contributor
|
Please see #25524 for why |
XhmikosR
force-pushed
the
v4-dev-xmr-offcanvas
branch
from
February 8, 2019 10:49
3d3eacd to
443abdd
Compare
This is more efficient.
XhmikosR
force-pushed
the
v4-dev-xmr-offcanvas
branch
from
February 8, 2019 10:50
443abdd to
dfc5a16
Compare
Member
Author
|
OK, I added back visibility. |
Contributor
|
These changes increase the file size, but it will be more efficient in the future. |
Member
Author
|
We need to promote the best practices. |
Contributor
|
If I am not misunderstanding your comment, I agree with these changes. |
Member
Author
|
Yeah, we say the same thing :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more efficient.
Opening this so that we don't forget about it.