Skip to content

Create border-top-left-radius and border-bottom-right-radius mixins - #28100

Merged
MartijnCuppens merged 7 commits into
twbs:v4-devfrom
hunkjazz:border-radius-corners
Feb 7, 2019
Merged

MartijnCuppens merged 7 commits into
twbs:v4-devfrom
hunkjazz:border-radius-corners

Conversation

@hunkjazz

Copy link
Copy Markdown
Contributor

I couldn't find the reason why there weren't mixins for the top-left and bottom-right corners. So I did it, anyway.

@hunkjazz
hunkjazz requested a review from a team as a code owner January 22, 2019 14:21
@MartijnCuppens MartijnCuppens added css Sass sources or compiled CSS v4 v4, the frozen docs on gh-pages labels Jan 22, 2019
@MartijnCuppens

Copy link
Copy Markdown
Member

Thanks @JLammeer!

Could you switch the positions of the mixins, this way the mixins will be defined in clockwise order?

João Lucas added 2 commits January 23, 2019 10:37
@hunkjazz

Copy link
Copy Markdown
Contributor Author

Done.

@ysds

ysds commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Should be add to blacklist in .stylelintrc 😉

@MartijnCuppens

Copy link
Copy Markdown
Member

@ysds, it looks like they are were already added

@ysds

ysds commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Wow! I did not check enough😱

@MartijnCuppens
MartijnCuppens merged commit eb1313d into twbs:v4-dev Feb 7, 2019
@mdo mdo mentioned this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css Sass sources or compiled CSS v4 v4, the frozen docs on gh-pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants