Skip to content

Fix text break in Firefox - #28063

Merged
XhmikosR merged 5 commits into
v4-devfrom
v4-dev-mc-ff-text-break-fix
Feb 6, 2019
Merged

XhmikosR merged 5 commits into
v4-devfrom
v4-dev-mc-ff-text-break-fix

Conversation

@MartijnCuppens

Copy link
Copy Markdown
Member

word-break: break-word doesn't work in Firefox, but I think hyphens: auto; is an acceptable workaround. I guess !important won't be nessesary for hyphens: auto;, but not 100% sure.

@XhmikosR

Copy link
Copy Markdown
Member

LGTM as a workaround. Maybe add a comment to revisit this.

@mdo

mdo commented Jan 20, 2019

Copy link
Copy Markdown
Member

Hmm, didn't know about this! Could overflow-wrap work?

Comment thread scss/utilities/_text.scss
@MartijnCuppens

Copy link
Copy Markdown
Member Author

Forgot to answer on this ticket, but it looked like overflow-wrap was indeed the best solution. I've kept word-break: break-word for backwards compatibility.

@XhmikosR
XhmikosR merged commit 58470c0 into v4-dev Feb 6, 2019
@XhmikosR
XhmikosR deleted the v4-dev-mc-ff-text-break-fix branch February 6, 2019 10:38
@mdo mdo mentioned this pull request Feb 6, 2019
@adamwathan

Copy link
Copy Markdown

Too late but I think what you actually want is word-wrap: break-word for old IE support, word-break is a different property with subtly different behavior and overflow-wrap is the newer name for word-wrap.

image

https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants