Repository navigation
Move z-index from .list-group-item to .list-group-item-action - #27996
Merged
Merged
Conversation
…decoration: none`
Member
|
|
Contributor
Author
|
Before: https://codepen.io/anon/pen/ebrqWJ Based on my experience working on z-index of bootstrap, seems fine to me I think, but would like feedback and more test case. |
Member
|
Here's another testcase with links, which looks fine: |
MartijnCuppens
approved these changes
Jan 7, 2019
MartijnCuppens
left a comment
MartijnCuppens
left a comment
Member
There was a problem hiding this comment.
Couldn't find anything that could go wrong.
mdo
approved these changes
Jan 8, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is more make sense if
z-indexis defined to.list-group-item-actionnot.list-group-item.And remove redundant
text-decoration: none;This fixes #25446, hopefully also #25206.