Skip to content

Cache ESLint and stylelint - #27989

Merged
XhmikosR merged 4 commits into
v4-devfrom
v4-dev-xmr-lint-cache
Jan 7, 2019
Merged

XhmikosR merged 4 commits into
v4-devfrom
v4-dev-xmr-lint-cache

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Jan 6, 2019

Copy link
Copy Markdown
Member

Generally it speed things up a lot. There are some cases like when changing rules that one needs to remove the cache, but other than that it should work fine.

Please test it out with your normal workflow.

@XhmikosR
XhmikosR force-pushed the v4-dev-xmr-lint-cache branch from 18b2a72 to 23373a8 Compare January 6, 2019 09:16
@XhmikosR
XhmikosR requested a review from a team as a code owner January 6, 2019 09:16
@MartijnCuppens

Copy link
Copy Markdown
Member

I tested the stylelint config and everything looked fine. I was a bit worried this config would conflict with the build-in linter from Webstorm, but everything looks ok.

However, we could gain some additional speed if we change the lint script to:
"lint": "npm-run-all --parallel js-lint-* css-lint-*",
This decreases the runtime from ~1.8s to ~1.4s on my machine
We can also change this on the other locations and maybe just remove the js-lint and css-lint scripts.

But we can maybe cover this in another PR if needed.

@MartijnCuppens MartijnCuppens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for stylelint (didn't test eslint too much)

@XhmikosR

XhmikosR commented Jan 6, 2019

Copy link
Copy Markdown
Member Author

The comment about the individual scripts is a little unrelated to this patch. This is a very specific change.

What you describe it's in my TODO but I still want to have the wrapper script. It's a lot more convenient.

@Johann-S

Johann-S commented Jan 7, 2019

Copy link
Copy Markdown
Member

it seems faster to me 👍

@mdo mdo mentioned this pull request Jan 7, 2019
@XhmikosR
XhmikosR merged commit b232414 into v4-dev Jan 7, 2019
@XhmikosR
XhmikosR deleted the v4-dev-xmr-lint-cache branch January 7, 2019 17:15
@XhmikosR

XhmikosR commented Jan 7, 2019

Copy link
Copy Markdown
Member Author

We'll see how this goes in the long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants