Skip to content

Remove screen from media query - #27985

Merged
XhmikosR merged 2 commits into
v4-devfrom
v4-dev-martijncuppens-remove-screen
Jan 7, 2019
Merged

XhmikosR merged 2 commits into
v4-devfrom
v4-dev-martijncuppens-remove-screen

Conversation

@MartijnCuppens

Copy link
Copy Markdown
Member

We don't use screen anywhere else in our media queries and there's no reason why we should disable it if the device is not a screen.

@MartijnCuppens
MartijnCuppens requested a review from a team as a code owner January 5, 2019 20:17
@XhmikosR XhmikosR added the v4 label Jan 5, 2019

@andresgalante andresgalante left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, and there is no motion on a screen reader or a paper :)

@mdo mdo mentioned this pull request Jan 7, 2019
@XhmikosR
XhmikosR merged commit 2b96e9a into v4-dev Jan 7, 2019
@XhmikosR
XhmikosR deleted the v4-dev-martijncuppens-remove-screen branch January 7, 2019 16:18
MartijnCuppens added a commit that referenced this pull request Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants