Repository navigation
Sync custom select focus with form control focus - #27963
Merged
Merged
Conversation
mdo
approved these changes
Jan 2, 2019
Member
|
Tests fail because |
Member
Author
|
I deleted the variable. Don't think that would break anything since this variable was used to construct |
Member
|
Hmm, don't think we can delete variables in v4 (backward compatibility). Maybe first deprecate them by reassigning their values? Unsure about the unused vars linter and how to whitelist something, if we can at all. |
MartijnCuppens
force-pushed
the
v4-dev-martijncuppens-custom-select-box-shadow
branch
from
January 5, 2019 12:18
c76b6b9 to
6a11ba6
Compare
Member
Author
|
I've tweaked the variable so that it makes use of |
mdo
approved these changes
Jan 6, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27944.