Skip to content

Prevent unnecessary CSS output for emphasized links - #27880

Merged
mdo merged 1 commit into
twbs:v4-devfrom
ysds:contextual-colors-level-var
Dec 21, 2018
Merged

Prevent unnecessary CSS output for emphasized links#27880
mdo merged 1 commit into
twbs:v4-devfrom
ysds:contextual-colors-level-var

Conversation

@ysds

@ysds ysds commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

If $emphasized-link-hover-darken-percentage is 0 or 0%, the overwrite for a is not necessary:

.text-primary {
  color: #0d67cb !important;
}

a.text-primary:hover, a.text-primary:focus {
  color: #0d67cb !important; // No need
}

This PR prevents unnecessary CSS output when $emphasized-link-hover-darken-percentage is 0 or 0%

@ysds
ysds requested a review from a team as a code owner December 19, 2018 07:35
MartijnCuppens
MartijnCuppens approved these changes Dec 19, 2018
View reviewed changes

@MartijnCuppens MartijnCuppens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @ysds!

@mdo
mdo merged commit 27d691c into twbs:v4-dev Dec 21, 2018
@mdo mdo mentioned this pull request Dec 21, 2018
Closed
@ysds
ysds deleted the contextual-colors-level-var branch January 7, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes
@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees

No one assigned

Labels

css v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ysds @mdo @MartijnCuppens