Skip to content

Add new .text-break utility for applying word-break: break-word - #27863

Merged
mdo merged 3 commits into
v4-devfrom
text-break-util
Dec 21, 2018
Merged

mdo merged 3 commits into
v4-devfrom
text-break-util

Conversation

@mdo

@mdo mdo commented Dec 16, 2018 •

Copy link
Copy Markdown
Member

If we need to be changing the breaking of content, we shouldn't be doing it piece meal on our components. A utility helps in the interim, hence this PR, but v5 will likely see this added to the <body> element in Reboot to solve the problem across the entire project. (At that point we'll likely need the opposite utility, too).

Fixes #19315.

@mdo
mdo requested a review from a team as a code owner December 16, 2018 21:25
Comment thread scss/utilities/_text.scss Outdated
@MartijnCuppens

Copy link
Copy Markdown
Member

Looks good, maybe add some documentation?

@mdo

mdo commented Dec 17, 2018

Copy link
Copy Markdown
Member Author

@MartijnCuppens Added!

@MartijnCuppens MartijnCuppens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@mdo
mdo merged commit f7bf353 into v4-dev Dec 21, 2018
@mdo mdo mentioned this pull request Dec 21, 2018
@XhmikosR
XhmikosR deleted the text-break-util branch December 22, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants