Fix margin above toast when previous toast is hidden - #27820
Merged
Merged
Conversation
MartijnCuppens
changed the title
Member
Author
|
Not sure if this fixes #27807, we still have an inconsistent behaviour between the alerts and toasts (alerts are removed from the DOM, toasts aren't) |
Member
|
I think it's not the same behavior we want for Alerts and Toasts. Alerts have a state (warning, error, info) and should be displayed once, on the other hand Toasts don't have states and can be reusable |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a margin above the second toast if we dismiss the first: https://deploy-preview-27792--twbs-bootstrap4.netlify.com/docs/4.1/components/toasts/#stacking
Demo solution: https://deploy-preview-27820--twbs-bootstrap4.netlify.com/docs/4.1/components/toasts/#stacking
Closes #27807