Repository navigation
docs: image updates - #27672
Merged
Merged
docs: image updates#27672
Conversation
XhmikosR
added
docs
| <p> | ||
| Take Bootstrap 4 to the next level with official premium themes—toolkits built on Bootstrap with new components and plugins, docs, and build tools. | ||
| </p> | ||
| <img class="img-fluid mt-3 mx-auto" src="{{ site.baseurl }}/docs/{{ site.docs_version }}/assets/img/bootstrap-themes.png" alt="Bootstrap Themes" width="1024" height="388"> |
Member
There was a problem hiding this comment.
I think we can save some bandwidth if we use a .jpg here, the file size of complex images tend to be higher with .png
Member
Author
There was a problem hiding this comment.
Last time I tried, we didn't save a lot with JPG 80%.
Member
Author
There was a problem hiding this comment.
@MartijnCuppens: I'm gonna merge this as is for now, but feel free to experiment with JPG for the themes image and example images later.
Member
Author
|
This reminds me, we should move the examples screenshots in |
XhmikosR
force-pushed
the
v4-dev-xmr-docs-2x-img
branch
from
November 17, 2018 11:33
1afd21e to
5b54847
Compare
Member
Author
|
I'll give jpeg a go again later. I still think we should have the stack image as SVG though. |
This should reduce the amount of bytes for non-2x displays.
XhmikosR
force-pushed
the
v4-dev-xmr-docs-2x-img
branch
2 times, most recently
from
November 27, 2018 12:42
ec1c526 to
7ca74b9
Compare
Johann-S
approved these changes
Nov 27, 2018
XhmikosR
changed the title
XhmikosR
force-pushed
the
v4-dev-xmr-docs-2x-img
branch
from
November 27, 2018 13:15
7ca74b9 to
fa480ad
Compare
It's pretty small compressed; a little less than 1 KB with gzip.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: