Prevent hover/click on disabled .close links - #26899
Merged
Merged
Conversation
Member
|
Unfortunately, |
Contributor
Author
|
yes, the same as https://getbootstrap.com/docs/4.1/components/buttons/#disabled-state |
Contributor
Author
|
I’ll add commit later to prevent visual changes on IE10. |
mdo
approved these changes
Oct 21, 2018
Member
|
@MartijnCuppens: LGTY? |
MartijnCuppens
previously requested changes
Oct 21, 2018
Member
|
Just for confirmation: LGTM now. |
Member
|
I still can't merge until the GitHub situation is over :P |
Member
|
@ysds: can you fetch upstream and rebase? |
Member
|
@ysds: this is not a rebase. |
Contributor
Author
|
@XhmikosR yes.. I made some mistake. What should I do? |
Member
|
Let me fix it for you. You can read a bit about interactive git rebase for the future :) |
Contributor
Author
|
Thanks :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.closeis supported with<a>, but it is still hoverable/clickable when it is disabled with the.disabledclass. This PR prevents hover/click on disabled .close links.Demo: