Skip to content

fix issues with calc - #26328

Closed
MartijnCuppens wants to merge 1 commit into
twbs:v4-devfrom
MartijnCuppens:calc-fixes
Closed

MartijnCuppens wants to merge 1 commit into
twbs:v4-devfrom
MartijnCuppens:calc-fixes

Conversation

@MartijnCuppens

@MartijnCuppens MartijnCuppens commented Apr 17, 2018 •

Copy link
Copy Markdown
Member

Fixes: #26206.

postcss-calc uses reduce-css-calc to reduce CSS calc() function. This also removes zero-values thus fixes #26206.

This also seems to solve the issue of nested calc functions. (Fixes #25717)

@Johann-S Johann-S added css Sass sources or compiled CSS v4 v4, the frozen docs on gh-pages labels Apr 18, 2018
@MartijnCuppens MartijnCuppens mentioned this pull request Apr 18, 2018
@XhmikosR

Copy link
Copy Markdown
Member

We've already tried this approach and @mdo didn't want to use postcss back then.

@XhmikosR
XhmikosR requested a review from mdo April 18, 2018 17:50
@mdo

mdo commented Apr 24, 2018

Copy link
Copy Markdown
Member

Deferring to #25724

@mdo mdo closed this Apr 24, 2018
@MartijnCuppens
MartijnCuppens deleted the calc-fixes branch May 1, 2018 15:41
@MartijnCuppens
MartijnCuppens restored the calc-fixes branch May 3, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css Sass sources or compiled CSS v4 v4, the frozen docs on gh-pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants