Repository navigation
Add coverall to follow our coverage - #25929
Merged
Merged
Conversation
Johann-S
force-pushed
the
v4-dev-johann-coverall
branch
2 times, most recently
from
March 23, 2018 14:50
e9fd3bc to
ae4f36a
Compare
XhmikosR
approved these changes
Mar 23, 2018
XhmikosR
left a comment
XhmikosR
left a comment
Member
There was a problem hiding this comment.
LGTM, but we should add the badge before merging :)
Member
|
@mdo: ping |
Member
Author
|
ping @mdo we need you 🙏 😆 |
Member
|
@Johann-S: I added this myself. Can you rebase? |
Member
|
Oh, and add the badge in README too. |
Johann-S
force-pushed
the
v4-dev-johann-coverall
branch
from
May 23, 2018 07:52
dde7a32 to
a2574dd
Compare
Member
Author
|
Thanks @XhmikosR, I added the badge 😉 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys !
I want to add Coverall to our repository because it'll help us to follow our coverage by adding a badge in our README.md plus it'll add comments in PRs which will indicate if our coverage is lower than before.
@mdo if you're ok with that, please see :
Edit:
Currently we have that, but it's normal :
/CC @XhmikosR @bardiharborow @cvrebert