Skip to content

Add basic position to dropup/right/left and dropdown-menu-right #25400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XhmikosR merged 5 commits into from
Mar 12, 2018
Merged

Add basic position to dropup/right/left and dropdown-menu-right #25400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
967b971
Add basic position to dropup/right/left
ysds Jan 16, 2018
06bd348
Reset basic dropdown position when enabled Popper.js,
ysds Jan 22, 2018
70373f5
Add basic position of .dropdown-menu-right
ysds Jan 22, 2018
5dad9c2
Remove unnecessary specific dropdown menu position on navbar
ysds Jan 22, 2018
0aa8562
Merge branch 'v4-dev' into dropdown-basic-position2
XhmikosR Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion scss/_dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// The dropdown wrapper (`<div>`)
.dropup,
.dropdown {
.dropright,
.dropdown,
.dropleft {
position: relative;
}

Expand Down Expand Up @@ -31,10 +33,17 @@
@include box-shadow($dropdown-box-shadow);
}

.dropdown-menu-right {
right: 0;
left: auto;
}

// Allow for dropdowns to go bottom up (aka, dropup-menu)
// Just add .dropup after the standard .dropdown class and you're set.
.dropup {
.dropdown-menu {
top: auto;
bottom: 100%;
margin-top: 0;
margin-bottom: $dropdown-spacer;
}
Expand All @@ -46,6 +55,9 @@

.dropright {
.dropdown-menu {
top: 0;
right: auto;
left: 100%;
margin-top: 0;
margin-left: $dropdown-spacer;
}
Expand All @@ -60,6 +72,9 @@

.dropleft {
.dropdown-menu {
top: 0;
right: 100%;
left: auto;
margin-top: 0;
margin-right: $dropdown-spacer;
}
Expand All @@ -72,6 +87,19 @@
}
}

// When enabled Popper.js, reset basic dropdown position
// stylelint-disable no-duplicate-selectors
.dropdown-menu {
&[x-placement^="top"],
&[x-placement^="right"],
&[x-placement^="bottom"],
&[x-placement^="left"] {
right: auto;
bottom: auto;
}
}
// stylelint-enable no-duplicate-selectors

// Dividers (basically an `<hr>`) within the dropdown
.dropdown-divider {
@include nav-divider($dropdown-divider-bg);
Expand Down
12 changes: 0 additions & 12 deletions scss/_navbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,6 @@
position: absolute;
}

.dropdown-menu-right {
right: 0;
left: auto; // Reset the default from `.dropdown-menu`
}

.nav-link {
padding-right: $navbar-nav-link-padding-x;
padding-left: $navbar-nav-link-padding-x;
Expand All @@ -189,13 +184,6 @@
.navbar-toggler {
display: none;
}

.dropup {
.dropdown-menu {
top: auto;
bottom: 100%;
}
}
}
}
}
Expand Down