Skip to content

Reduce whitespace liquid outputs. - #24470

Merged
XhmikosR merged 2 commits into
v4-devfrom
v4-dev-xmr-reduce-liquid-whitespace
Oct 22, 2017
Merged

XhmikosR merged 2 commits into
v4-devfrom
v4-dev-xmr-reduce-liquid-whitespace

Conversation

@XhmikosR

Copy link
Copy Markdown
Member

@mdo: alternatively we can remove the whole comment block.

@XhmikosR XhmikosR added docs Documentation site and its content v4 v4, the frozen docs on gh-pages labels Oct 20, 2017
@XhmikosR
XhmikosR requested a review from mdo October 20, 2017 14:58
@XhmikosR
XhmikosR force-pushed the v4-dev-xmr-reduce-liquid-whitespace branch from 840d794 to b909138 Compare October 20, 2017 15:53
@XhmikosR

Copy link
Copy Markdown
Member Author

@mdo: I added one more patch which fixes the pages' description. Previously the generic site's description was being used.

@XhmikosR
XhmikosR force-pushed the v4-dev-xmr-reduce-liquid-whitespace branch from b909138 to 83e3dc6 Compare October 20, 2017 15:55
@XhmikosR XhmikosR changed the title Reduce whitespace liquid outputs. Reduce whitespace liquid outputs and simplify social.html. Oct 20, 2017
Comment thread _includes/social.html Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be possible to simplify more by just using {{ site.url }}{{ page.url }} since for the index page

@XhmikosR
XhmikosR force-pushed the v4-dev-xmr-reduce-liquid-whitespace branch 2 times, most recently from 72e6565 to 0eeae14 Compare October 20, 2017 20:16
@XhmikosR XhmikosR changed the title Reduce whitespace liquid outputs and simplify social.html. Reduce whitespace liquid outputs. Oct 21, 2017
@XhmikosR
XhmikosR merged commit fbd42af into v4-dev Oct 22, 2017
@XhmikosR
XhmikosR deleted the v4-dev-xmr-reduce-liquid-whitespace branch October 22, 2017 11:53
@mdo mdo mentioned this pull request Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation site and its content v4 v4, the frozen docs on gh-pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants