Skip to content

Drop Bower support - #23568

Merged
mdo merged 4 commits into
twbs:v4-devfrom
tkrotoff:drop-bower
Sep 4, 2017
Merged

mdo merged 4 commits into
twbs:v4-devfrom
tkrotoff:drop-bower

Conversation

@tkrotoff

@tkrotoff tkrotoff commented Aug 19, 2017 •

Copy link
Copy Markdown
Contributor

Bower is deprecated.

screen shot 2017-08-19 at 19 09 46

See bower/bower#2298

Dropping Bower will allow to split Bootstrap in multiple npm packages, see #23557 (comment) and following comments.

Ping @XhmikosR

@Johann-S Johann-S added meta The repository itself: templates, guidelines, config v4 v4, the frozen docs on gh-pages labels Aug 20, 2017
@XhmikosR
XhmikosR requested a review from mdo August 20, 2017 06:49
@XhmikosR

Copy link
Copy Markdown
Member

@tkrotoff: maybe this solution would be better?

@mdo: please chime in; it is sort of a breaking change but Bower seems to be absolete nowadays, so it would be better if we provided a proper npm way to do things as we discussed in #23557

@mdo

mdo commented Aug 20, 2017

Copy link
Copy Markdown
Member

Asked Twitter to weigh in :D. I'm unsure on overall usage—I don't think Bower ever had install stats like npm does on their packages. Hard to know how used it is.

@jerguslejko

Copy link
Copy Markdown

I vote: "drop it".

@rowdyrabouw

Copy link
Copy Markdown

Drop it vote!

@auvipy

auvipy commented Aug 20, 2017

Copy link
Copy Markdown

drop it

@deadbirdi

Copy link
Copy Markdown

Drop it

@chyvak1831

Copy link
Copy Markdown

keep it

@dfosco

dfosco commented Aug 20, 2017

Copy link
Copy Markdown

If it means Bootstrap having multiple npm packages, I'm all in for dropping bower.

@deadbirdi

Copy link
Copy Markdown

@chyvak1831 I feel like the argument for dropping is there. Do you have an argument for keeping it?

@Arseur

Arseur commented Aug 20, 2017

Copy link
Copy Markdown

I happen to use Bootstrap via Bower but would be happy to hear of a better way to proceed.

@dRagonsRage

Copy link
Copy Markdown

Keep it

@alexdreptu

Copy link
Copy Markdown

Drop it. There's no need for it to exist anymore. It's better for everyone to focus entirely on npm.

@igghera

igghera commented Aug 20, 2017

Copy link
Copy Markdown

Drop it

1 similar comment
@cto1

cto1 commented Aug 20, 2017

Copy link
Copy Markdown

Drop it

@cba85

cba85 commented Aug 20, 2017

Copy link
Copy Markdown

Drop it like it's hot

@ernitishkumar

Copy link
Copy Markdown

Dracarys

@matthew-inamdar

Copy link
Copy Markdown

Drop it

@cvrebert

Copy link
Copy Markdown
Collaborator

Drop it. It's been abandoned and practically superseded by npm for a while now.

@XhmikosR

Copy link
Copy Markdown
Member

So @mdo it seems most people are in favor of this. Only concern is VS?

@christopherdarling

Copy link
Copy Markdown

Drop it

3 similar comments
@mgwoolf

mgwoolf commented Aug 20, 2017

Copy link
Copy Markdown

Drop it

@jloosli

jloosli commented Aug 20, 2017

Copy link
Copy Markdown

Drop it

@UlisesCabrera

Copy link
Copy Markdown

Drop it

@dw-roth

dw-roth commented Aug 20, 2017

Copy link
Copy Markdown

drop

@blikblum

Copy link
Copy Markdown

Drop

@curtsheller

Copy link
Copy Markdown

Drop It!

@tkrotoff

Copy link
Copy Markdown
Contributor Author

@XhmikosR @cvrebert About bower.json @$% Not a Bower package... ^&* like in Bootlint can you explain how this works?

@cvrebert

cvrebert commented Aug 21, 2017 •

Copy link
Copy Markdown
Collaborator

@tkrotoff That's just blatantly invalid JSON to make it clear that Bootlint deliberately doesn't support Bower. If there wasn't a bower.json, I'm sure we'd get pull requests adding one or issues asking for one.

@PhillipMwaniki

Copy link
Copy Markdown

Keep it.

@myplaneticket

Copy link
Copy Markdown

keep it

@kanhaic

kanhaic commented Aug 21, 2017

Copy link
Copy Markdown

Drop it npm is better.

@ph1p

ph1p commented Aug 21, 2017

Copy link
Copy Markdown

Drop it.

@kvz

kvz commented Aug 21, 2017

Copy link
Copy Markdown

There's so many fundamental issues with bower that, even if it causes breakage in cases, even for myself, I'd vote drop it. We'll fix those cases and move the whole ecosystem to brighter future with npm catering to all our packaging needs. If twbs sets this example I'm sure many will follow suit 👍❤️

@tkrotoff

tkrotoff commented Aug 21, 2017 •

Copy link
Copy Markdown
Contributor Author

@XhmikosR @cvrebert I've git rewrote history and kept bower.json with @$% Not a Bower package... ^&* in it.

@mhsnook

mhsnook commented Aug 21, 2017

Copy link
Copy Markdown

I vote drop.

Bower is kind of dead to me nowadays.

@xpose2000

Copy link
Copy Markdown

Keep. I still use bower.

@benmann

benmann commented Aug 22, 2017

Copy link
Copy Markdown

I'd decide based on the workload it creates to still support Bower. It's always nice to keep backwards compatibility, however if it involves some serious work on your end and is possibly blocking a more modular approach (which could likely be achieved with Bower as well?!) I'd say go with npm/yarn instead.

@tkrotoff

tkrotoff commented Aug 22, 2017 •

Copy link
Copy Markdown
Contributor Author

Bootstrap 3 will continue to be available with Bower. This only applies to v4. If you have an old project, this changes nothing.
If you create or upgrade a project to cutting edge Bootstrap 4, it does not make sense to rely on a deprecated tool for your project.

And Bower is deprecated, really:

  • Bower website displays the deprecation notice
  • same for the README:

screen shot 2017-08-21 at 12 12 17

  • and even when installing Bower:
$ npm install bower
npm WARN deprecated bower@1.8.0: ..psst! While Bower is maintained,
we recommend Yarn and Webpack for *new* front-end projects!
Yarn's advantage is security and reliability,
and Webpack's is support for both CommonJS and AMD projects.
Currently there's no migration path,
but please help to create it: https://github.com/bower/bower/issues/2467

To all people who replied "Keep it", why?

@peternewnham

Copy link
Copy Markdown

Does dropping Bower also mean that all the compiled code in dist/ and js/dist/ can be removed and ignored from the repo or is there still a reason to include it?

@Johann-S

Copy link
Copy Markdown
Member

We use our dist files for our documentation too, so they'll stay if we drop Bower

@benmann

benmann commented Aug 23, 2017

Copy link
Copy Markdown

Bootstrap 3 will continue to be available with Bower. This only applies to v4. If you have an old project, this changes nothing.

As we're also advising people to use yarn/webpack for new projects, this sounds like a neat solution. 👯

@smilingpeanut

Copy link
Copy Markdown

I vote for keeping Bower support.

@JulianTenschert

Copy link
Copy Markdown

Please drop it.

@robertpetras

Copy link
Copy Markdown

Drop it.

@mdo
mdo merged commit c770e68 into twbs:v4-dev Sep 4, 2017
This was referenced Sep 4, 2017
@tkrotoff
tkrotoff deleted the drop-bower branch September 4, 2017 23:28
@twbs twbs locked and limited conversation to collaborators Sep 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

meta The repository itself: templates, guidelines, config v4 v4, the frozen docs on gh-pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.