Conversation
- Drops the `if-supports-3d-transforms()` mixin since all our browsers do support it - Updates carousel to not rely on that mixin
This was referenced Apr 8, 2017
Closed
|
Still doesn't works for me (only Chrome) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few carousel issues.
Ensures carousel works in IE10 and IE11 by removing the
transform3ddetection mixin entirely as all our supported browsers support it. There was no fallback being provided, so IE10/11 were left in the dark as we were keying off-webkitdetection. Fixes [BS4] Carousel not working well in IE11. #22198.Fixes the image aspect ratio issues. Also moved from
.img-fluidto.w-100in our examples. Pulls in @vanduynslagerp's fix from Prevent images in carousel-item to be stretched #21799. Fixes Carousel plugin dont save aspect ratio of images #21658, fixes Carousel Responsive Issue In Chrome #21966, closes Prevent images in carousel-item to be stretched #21799.Changes the timing function from
ease-in-outtoeaseto fix the "bouncing" into place when carousel items move. This kinda sucks, but there's no other CSS change I can see us making to fix this issue. Fixes Carousel slider bouncing on the lefthand side when it slides #21685, fixes Carousel slide animation bounces slightly on completion [iOS9/Safari] #21751, fixes v4: Carousel animation bouncing on Microsoft Edge #22291.