Skip to content

Use of-type in Input Groups instead of child - #12687

Closed
montchr wants to merge 1 commit into
twbs:masterfrom
montchr:st-of-type
Closed

montchr wants to merge 1 commit into
twbs:masterfrom
montchr:st-of-type

Conversation

@montchr

@montchr montchr commented Feb 11, 2014

Copy link
Copy Markdown

Using the :first-child and :last-child pseudo-selectors
in Input Groups assumes that there are no other elements
before or after the element selected.

That can be problematic when using something like text-hide()
to use a form label prior to the addon.

This could apply in other parts of the codebase, but at the
moment I'm only concerned with Input Groups.

Using the `:first-child` and `:last-child` pseudo-selectors
in Input Groups assumes that there are no other elements
before or after the element selected.

That can be problematic when using something like `text-hide()`
to use a form label prior to the addon.
@mdo

mdo commented Feb 11, 2014

Copy link
Copy Markdown
Member

IE8 support, yo :). Can't do this until v4 when we drop IE8.

@mdo mdo closed this Feb 11, 2014
@montchr

montchr commented Feb 11, 2014

Copy link
Copy Markdown
Author

@mdo Aha, of course.

@mdo

mdo commented Feb 11, 2014

Copy link
Copy Markdown
Member

<3

@montchr
montchr deleted the st-of-type branch February 11, 2014 03:41
@mdo mdo mentioned this pull request Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants