Docs: carousel, collapse, navs (tabs), popovers should use buttons rather than faked link buttons #31186
Description
There's no good reason (other than ease of styling) for https://v5.getbootstrap.com/docs/5.0/components/carousel/, https://v5.getbootstrap.com/docs/5.0/components/collapse/, https://v5.getbootstrap.com/docs/5.0/components/navs/#javascript-behavior, https://v5.getbootstrap.com/docs/5.0/components/popovers/#dismiss-on-next-click to use <a href="#..." role="button">...</a> pseudo-buttons. While sure, BS can still support this, it'd be good to lead by example and use the correct <button> element for this (though I don't believe we have a neutral-enough button style out of the box to support carousel buttons...or at least, the current carousel controls need to be extended to neutralise the remaining button styles that creep in when swapping out the elements).
Activity
[-]Docs: carousel should use buttons rather than faked link buttons[/-][+]Docs: carousel, collapse, navs (tabs), popovers should use buttons rather than faked link buttons[/+]divya661 commentedon Sep 25, 2020
@XhmikosR I would like to work on this part of improving the documentation. I'll update the team regarding it as soon as possible. Can you assign this to me?
XhmikosR commentedon Sep 26, 2020
We don't assign issues to people and there's no need to ask for permission :) Just grab an issue, work on it and make a PR when ready.
divya661 commentedon Sep 26, 2020
@patrickhlauke @XhmikosR I'm currently working on it and got stuck in this https://v5.getbootstrap.com/docs/5.0/components/navs/#javascript-behavior Could you please provide any advice about replacing the anchor tag with the button on this part, if I have understood this issue properly?
patrickhlauke commentedon Dec 27, 2020
Carousels will be addressed by #32627 and #32661
Dynamic tabs will be addressed by #32630
Collapse components now already use buttons in the examples, though it should be made clear that that's the preferred option #32632
Popovers can't currently be changed to buttons due to a bug/shortcoming of Safari and Firefox/macOS (as buttons there don't fire focus event when clicked with the mouse...urgh)
patrickhlauke commentedon Feb 9, 2021
Closing this as - apart from popovers using links, which is still necessary with our current approach due to Safari/macOS's odd duck behaviour, copied by Firefox/macOS - all major things are now sorted.