.show class leaked on navlink #28118

Activity

1. XhmikosR

   added

   js

   v4

   on Jan 25, 2019
2. XhmikosR commented on Jan 25, 2019

   

   XhmikosR

   on Jan 25, 2019

   Last edited by XhmikosR

   Member

   More actions

   /CC @Johann-S

   Must be a regression from #27533
3. Johann-S commented on Jan 28, 2019

   

   Johann-S

   on Jan 28, 2019

   Member

   More actions

   Yep I think too, maybe @MartijnCuppens wants to fix that ?

   👍React with 👍1Reacted by Martijn Cuppens
4. XhmikosR commented on Feb 2, 2019

   

   XhmikosR

   on Feb 2, 2019

   Member

   More actions

   @MartijnCuppens: any progress with this?
5. MartijnCuppens

   self-assigned this

   on Feb 2, 2019
6. MartijnCuppens commented on Feb 2, 2019

   

   MartijnCuppens

   on Feb 2, 2019

   Member

   More actions

   I forgot about this, I'll have a look at it now and check if we can write a test to prevent this from happening.
7. MartijnCuppens commented on Feb 2, 2019

   

   MartijnCuppens

   on Feb 2, 2019

   Member

   More actions

   Reverting https://github.com/twbs/bootstrap/pull/27533/files#diff-02a6d2619ddbbd65ac148de3377674eeL174 would indeed "fix" this issue, but there's another issue here: we shouldn't add the .show class on the .nav-link in any case.

   Let's analyse these lines:
   

   bootstrap/js/src/tab.js

   Lines 111 to 133 in f134d4b

   	this._activate(
   	this._element,
   	listElement
   	)
   	const complete = () => {
   	const hiddenEvent = $.Event(Event.HIDDEN, {
   	relatedTarget: this._element
   	})
   	const shownEvent = $.Event(Event.SHOWN, {
   	relatedTarget: previous
   	})
   	$(previous).trigger(hiddenEvent)
   	$(this._element).trigger(shownEvent)
   	}
   	if (target) {
   	this._activate(target, target.parentNode, complete)
   	} else {
   	complete()
   	}

   The _activate function is triggered on .tab-pane and .nav-link. In L111 the show class will be added to the target .tab-pane and in L130 the class will be added to the .nav-link. Not sure why.

   @Johann-S could you help here?
8. MartijnCuppens

   removed their assignment

   on Feb 2, 2019
9. Johann-S

   closed this as completedin #28183on Feb 6, 2019