Skip to content

Issue with IE11 and Bootstrap 4.1.0 #26327

Description

@dustinrowland12

Hi,

I am running into a bug in IE11 with Bootstrap 4.1.0. I think it has to do with IE11 not fully supporting ES6. The bug happens in the following function. If I call $("#id").modal() (so there are no arguments passed when calling the function), then the code will break on Object.keys(source) because source evaluates to "false" here.

function _objectSpread(target) {
for (var i = 1; i < arguments.length; i++) {
var source = arguments[i] != null ? arguments[i] : {};
var ownKeys = Object.keys(source); <-- (code breaks here on 3rd iteration of loop)

The specific error I get in the IE11 Developer Tools console is "Object.keys: argument is not an Object".

If I do $("#id").modal({}) (so there is an empty object as an argument to the function), it works just fine.

I also found this resource on Object.keys(): https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys
That resource mentions the issue with ES5 and passing in non-object types.

Anyway, Bootstrap 4.0.0 does not have this issue, so we are using that for now. I'd like to use the latest though, so if this can be fixed in a newer version, please do so!

Activity

  1. dustinrowland12 commented on Apr 17, 2018

    @dustinrowland12
    Author

    bootstrap error

    To add more information, I created a code pen: https://codepen.io/dustinrowland12/pen/GdKzKL
    IE11 on Windows 10, Bootstrap version 4.1.0

  2. Johann-S commented on Apr 18, 2018

    @Johann-S
    Member

    Already fixed by: #26291 and will be available in our next release 👍

  3. dustinrowland12 commented on Apr 18, 2018

    @dustinrowland12
    Author

    Thank you for the quick reply. Any thoughts on when the next release may come out? I'm sure that is always the golden question. I just want to be on the lookout for it.

    Thanks again!

  4. Johann-S commented on Apr 18, 2018

    @Johann-S
    Member

    We'll try to release a new version soon to fix some critical bugs. It'll be a 4.1.1 😉

  5. catbadger commented on Apr 20, 2018

    @catbadger

    Sorry to prod, but we're pushing back release for 4.1.1. Is there a timeline for 4.1.1 yet?

  6. kosinix commented on Jun 1, 2018

    @kosinix

    Should remove <=IE11 from the list of supported browsers until then.

  7. Johann-S commented on Jun 1, 2018

    @Johann-S
    Member

    @kosinix 4.1.1 is already out 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions