Buttons in sample accordion don't have type="button" #25860

Activity

1. patrickhlauke

   closed this as completedon Mar 15, 2018
2. franktopel commented on Mar 15, 2018

   

   franktopel

   on Mar 15, 2018

   Last edited by franktopel

   Author

   More actions

   @patrickhlauke It'd be helpful if you checked before closing. The issue still exists. Most people I know work with Bootstrap by going to the documentation and then copy/paste the code shown there. That sample code displayed on the page has buttons with no type attribute.
3. wolfy1339 commented on Mar 15, 2018

   

   wolfy1339

   on Mar 15, 2018

   Contributor

   More actions

   @franktopel The docs in the repo already contain the fix. The live docs aren't synced to the repo.
4. franktopel commented on Mar 15, 2018

   

   franktopel

   on Mar 15, 2018

   Last edited by franktopel

   Author

   More actions

   Ah, thanks for the information. I was expecting the docs to always reflect the current "master" - which means the code I get when doing npm install bootstrap.
5. wolfy1339 commented on Mar 15, 2018

   

   wolfy1339

   on Mar 15, 2018

   Last edited by wolfy1339

   Contributor

   More actions

   Actually, that's wrong too. npm install bootstrap installs the code for the latest stable version (which right now is v4.0.0) not the current "master"
6. patrickhlauke commented on Mar 15, 2018

   

   patrickhlauke

   on Mar 15, 2018

   Member

   More actions

   the npm package, and what you get on getbootstrap.com, relate to stable releases. after a stable release, work continues on the repo (with changes, fixes, etc) until the next release...
7. patrickhlauke commented on Mar 15, 2018

   

   patrickhlauke

   on Mar 15, 2018

   Member

   More actions

   (of course, if that wasn't clear, it could have been discussed over on #25859 instead of opening a new issue...but anyway)
8. twbs

   locked and limited conversation to collaborators on Mar 15, 2018