Skip to content

Migration docs: Says badge are dropped #25746

Description

@henriksjodahl

I was going through the migration from bs3 to bs4 and found that the migration guide says:

Renamed .label to .tag to disambiguate from the element.
Dropped the .badge component as it was nearly identical to labels/tags. Use the .tag-pill modifier together with the label component instead for that rounded look.

But according to the documentation Badges still exists and tags do not

https://v4-alpha.getbootstrap.com/migration/#labels-badges-and-tags

Activity

  1. patrickhlauke commented on Mar 1, 2018

    @patrickhlauke
    Member

    shouldn't look at alpha docs. current stable docs are here https://getbootstrap.com/docs/4.0/migration/#labels-and-badges

    however you're right, seems that part of the migration doc related to some earlier change, does not reflect what 4.0 does (it removed labels in the end, not badges https://getbootstrap.com/docs/4.0/components/badge/)

  2. henriksjodahl commented on Mar 1, 2018

    @henriksjodahl
    Author

    Oh I didn't see that I was on the alpha (I blame Google).

  3. wolfy1339 commented on Mar 1, 2018

    @wolfy1339
    Contributor

    This problem has been raised may times before where people get the alpha docs instead of the current docs.
    Maybe someone should ask google to remove it altogether, and remove those docs too. Redirect them to the current docs saying that Bootstrap is now stable and to use these docs instead

  4. patrickhlauke commented on Mar 1, 2018

    @patrickhlauke
    Member

    i'd say the onus is on us to signpost the fact that that doc relates to the alpha, and to refer back to the stable docs/release.

    however, in substance the problem is the same even on our stable docs. the migration says badges have been removed, when they haven't.

  5. mdo commented on Mar 3, 2018

    @mdo
    Member

    The v4-alpha docs were so prolifically linked that I felt it important to keep them around. There is a prominent sticky header at the top to point folks to the newer releases, but we can probably do more for that.

  6. patrickhlauke commented on Mar 4, 2018

    @patrickhlauke
    Member

    @mdo probably expanding the text beyond "there's a new bootstrap version" and more "this documentation refers to an alpha version of bootstrap. please refer to the latest stable release version..." or something

  7. patrickhlauke commented on Mar 4, 2018

    @patrickhlauke
    Member

    however, back on main topic: any idea about the badge/label thing?

  8. kevinruscoe commented on Mar 4, 2018

    @kevinruscoe

    https://getbootstrap.com/docs/4.0/migration/#labels-and-badges

    The example doesn't make sense.

    Renamed .label to .badge to disambiguate from the element.

    Dropped the .badge component as it was nearly identical to labels. Use the .badge-pill modifier together with the label component instead for that rounded look.

    What was actually dropped? .badge clearly wasn't as it goes on the say "use the badge- modifiers".

  9. wolfy1339 commented on Mar 4, 2018

    @wolfy1339
    Contributor

    The old badge component from v3 was dropped and labels were renamed to badges

  10. mdo commented on Mar 4, 2018

    @mdo
    Member

    Correct. Badges are still in and it needs updating. I’ll fix it up.

  11. added a commit that references this issue on Jun 27, 2018
    4f1a652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsDocumentation site and its content

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions