Skip to content

.carousel-fade and animated progress bar don't seem to use transition mixin #25709

Closed

Description

@patrickhlauke

Per #25641 (comment) is seems that even when disabling transitions (using $enable-transitions or after setting the "prefers reduced motion" option once that PR has landed), .carousel-fade (https://github.com/twbs/bootstrap/blob/3dd0bde664699fc7a191d0d3569f4f0ba8f06028/docs/4.0/components/carousel.md#crossfade) and the animated progress bar https://getbootstrap.com/docs/4.0/components/progress/#animated-stripes still use transitions. Possibly (not tested) even the JS-based fade https://getbootstrap.com/docs/4.0/components/list-group/#fade-effect

All these effects should be suppressed when $enable-transitions is off / "prefers reduced motion" is indicated by the user.

Activity

  1. added
    cssSass sources or compiled CSS
    accessibilityKeyboard, screen readers, contrast, ARIA
    v4v4, the frozen docs on gh-pages
    jsJavaScript or TypeScript sources and plugins
    on Feb 25, 2018
  2. mdo commented on Jun 21, 2018

    @mdo
    Member

    Given the referenced PR was merged, save to close?

  3. patrickhlauke commented on Jul 3, 2018

    @patrickhlauke
    MemberAuthor

    No, the referenced PR addressed the reduced motion stuff which sets/unsets the the transitions variable. This issue points out that the carousel fade and animated progress bar are not conditional on that transitions variable (regardless of whether $enable-transitions is on or off / "prefers reduced motion" is set in the UA, carousels do animated fades and animated progress bars animate - they shouldn't/should obey those)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    accessibilityKeyboard, screen readers, contrast, ARIAcssSass sources or compiled CSShas-prAn open pull request addresses itjsJavaScript or TypeScript sources and pluginsv4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions