Skip to content

Theming Bootstrap file structure documentation #24728

Description

@NYCJacob

It seems to me there is an error in explaining the file structure for customizing bootstrap as explained in this link (https://getbootstrap.com/docs/4.0/getting-started/theming/#file-structure)

  • In the section Sass - File Structure
    -- it states, Assuming you’ve downloaded our source files or are using a package manager, you’ll have a file structure that looks like this:
    your-project/
    ├── scss
    │ └── custom.scss
    └── node_modules/
    └── bootstrap
    ├── js
    └── scss
    -- this is not what I have from the repo here nor from the source files download
    -- I see two errors
    1- there is no file custom.scss
    2- if you download the source files they are not located in node_modules. They would be if using npm but this seems to combine the two methods

-- I would be happy to work on this if it is deemed needed.

Activity

  1. added
    docsDocumentation site and its content
    v4v4, the frozen docs on gh-pages
    on Nov 9, 2017
  2. andresgalante commented on Nov 13, 2017

    @andresgalante
    Collaborator

    Hi @NYCJacob

    Assuming you’ve are using a package manager you would get a node_modules/ folder, and the custom.scss file is something that belongs to your project, you wouldn't get it from installing bootstrap.

    If you read the whole paragraph and the next one I think it's explicit of that idea, but if you have a suggestion to reword it better, make please send a PR so we can review a more concrete proposal.

    Thanks!

  3. added a commit that references this issue on Dec 1, 2017
    ccf3fb2
  4. added a commit that references this issue on Dec 2, 2017
    9de141f
  5. added a commit that references this issue on Dec 8, 2017
    278a4bc
  6. added a commit that references this issue on Dec 30, 2017
    ea1c866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsDocumentation site and its contentv4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions