Skip to content

Issues for .fixed-top/.fixed-bottom navbars (Bootstrap v4.0.0-beta) #24260

Closed

Description

@vadikom

Hey guys, here's a short list of issues I stumbled upon in Bootstrap v4.0.0-beta (while working on the Bootstrap 4 addon for SmartMenus jQuery):

  1. For .fixed-top/.fixed-bottom navbars .navbar-collapse doesn't have something like overflow-y: auto; max-height: 360px; (as in BS3) so the content cannot be scrolled and might be cut if too tall.
  2. For .fixed-bottom navbars dropdowns are not properly positioned above the navbar.
  3. For .fixed-bottom navbars .dropdown-toggle carets do not point up.

All these are demonstrated and can be tested here:

https://codepen.io/vadikom/pen/EwoKyz

Activity

  1. Johann-S commented on Oct 5, 2017

    @Johann-S
    Member

    For your two last points :
    if you want dropdowns positionned above the navbar use .dropup

    Side note: in beta 1 we have issue with dropup in navbar but it's already fixed in our current code and will be available in our next release

    btw nice plugin 😉

  2. added
    cssSass sources or compiled CSS
    v4v4, the frozen docs on gh-pages
    on Oct 5, 2017
  3. vadikom commented on Oct 5, 2017

    @vadikom
    Author

    Ah, I missed .dropup, thanks!

    BTW, sorry for a dumb question I guess - in which branch is your most current dropdown code? Thanks!

  4. Johann-S commented on Oct 5, 2017

    @Johann-S
    Member

    use our v4-dev branch 👍

  5. mdo commented on Oct 18, 2017

    @mdo
    Member

    Oh man we could totally use viewport units for the fixed navbar now. v3 didn't allow for it given browser support, but we can definitely do it now. http://caniuse.com/#feat=viewport-units

  6. XhmikosR commented on Oct 19, 2017

    @XhmikosR
    Member

    @Johann-S @mdo: that is why the bottom navbar example doesn't look good in small res? I haven't had the time to dig into this, just noticed it.

    screen shot 2017-10-20 at 02 00 32-fullpage

  7. added
    has-prAn open pull request addresses it
    on Oct 21, 2017
  8. mukhammad-akilov commented on Oct 23, 2017

    @mukhammad-akilov

    Don't you forget about max-height: % and overflow-y: scroll for .navbar-collapse if navbar is fixed?

  9. mdo commented on Nov 15, 2017

    @mdo
    Member

    Punting second part of this to #24796.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cssSass sources or compiled CSShas-prAn open pull request addresses itv4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions