Issues for .fixed-top/.fixed-bottom navbars (Bootstrap v4.0.0-beta) #24260
Copy link
Copy link
Closed
Labels
cssSass sources or compiled CSSSass sources or compiled CSShas-prAn open pull request addresses itAn open pull request addresses itv4v4, the frozen docs on gh-pagesv4, the frozen docs on gh-pages
Description
Hey guys, here's a short list of issues I stumbled upon in Bootstrap v4.0.0-beta (while working on the Bootstrap 4 addon for SmartMenus jQuery):
- For
.fixed-top/.fixed-bottomnavbars.navbar-collapsedoesn't have something likeoverflow-y: auto; max-height: 360px;(as in BS3) so the content cannot be scrolled and might be cut if too tall. - For
.fixed-bottomnavbars dropdowns are not properly positioned above the navbar. - For
.fixed-bottomnavbars.dropdown-togglecarets do not point up.
All these are demonstrated and can be tested here:
Metadata
Metadata
Assignees
Labels
cssSass sources or compiled CSSSass sources or compiled CSShas-prAn open pull request addresses itAn open pull request addresses itv4v4, the frozen docs on gh-pagesv4, the frozen docs on gh-pages
Activity
Johann-S commentedon Oct 5, 2017
For your two last points :
if you want dropdowns positionned above the navbar use
.dropupSide note: in beta 1 we have issue with dropup in navbar but it's already fixed in our current code and will be available in our next release
btw nice plugin 😉
vadikom commentedon Oct 5, 2017
Ah, I missed
.dropup, thanks!BTW, sorry for a dumb question I guess - in which branch is your most current dropdown code? Thanks!
Johann-S commentedon Oct 5, 2017
use our
v4-devbranch 👍mdo commentedon Oct 18, 2017
Oh man we could totally use viewport units for the fixed navbar now. v3 didn't allow for it given browser support, but we can definitely do it now. http://caniuse.com/#feat=viewport-units
XhmikosR commentedon Oct 19, 2017
@Johann-S @mdo: that is why the bottom navbar example doesn't look good in small res? I haven't had the time to dig into this, just noticed it.
mukhammad-akilov commentedon Oct 23, 2017
Don't you forget about
max-height: %andoverflow-y: scrollfor.navbar-collapseif navbar is fixed?mdo commentedon Nov 15, 2017
Punting second part of this to #24796.