Skip to content

Outline button hover should apply same darken as filled button. #24144

Closed

Description

@afholderman

If you have two buttons with the same theme color next to one another, one filled and one outline, the outline button's hover state is visually confusing. When hovered it fills and matches the already filled button exactly. When the outline button it hovered the color should fill and have the same darken applied as the standard button to prevent this.

https://codepen.io/afholderman/pen/rGyqbK

Activity

  1. barclay13 commented on Sep 27, 2017

    @barclay13

    Good spot, that does make it confusing.

  2. afholderman commented on Sep 27, 2017

    @afholderman
    ContributorAuthor

    If you would like I can submit a PR altering the mixin to perform the same way as the filled button.

  3. added
    cssSass sources or compiled CSS
    v4v4, the frozen docs on gh-pages
    on Sep 27, 2017
  4. andresgalante commented on Sep 27, 2017

    @andresgalante
    Collaborator

    @afholderman please send a PR, and good catch!

  5. afholderman commented on Sep 27, 2017

    @afholderman
    ContributorAuthor

    PR open here: #24150

  6. added
    has-prAn open pull request addresses it
    on Oct 18, 2017
  7. mdo commented on Nov 25, 2017

    @mdo
    Member

    I agree the mixin should be updated and these colors should be customizable, but I'm going to merge the PR with the current values to keep the look of these as I originally intended. We can revisit eventually, but for now I'd like to keep the default colors.

  8. added a commit that references this issue on Dec 1, 2017
  9. added a commit that references this issue on Dec 8, 2017
  10. added a commit that references this issue on Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cssSass sources or compiled CSShas-prAn open pull request addresses itv4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions