You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Outline button hover should apply same darken as filled button. #24144
If you have two buttons with the same theme color next to one another, one filled and one outline, the outline button's hover state is visually confusing. When hovered it fills and matches the already filled button exactly. When the outline button it hovered the color should fill and have the same darken applied as the standard button to prevent this.
I agree the mixin should be updated and these colors should be customizable, but I'm going to merge the PR with the current values to keep the look of these as I originally intended. We can revisit eventually, but for now I'd like to keep the default colors.
Activity
barclay13 commentedon Sep 27, 2017
Good spot, that does make it confusing.
afholderman commentedon Sep 27, 2017
If you would like I can submit a PR altering the mixin to perform the same way as the filled button.
andresgalante commentedon Sep 27, 2017
@afholderman please send a PR, and good catch!
afholderman commentedon Sep 27, 2017
PR open here: #24150
mdo commentedon Nov 25, 2017
I agree the mixin should be updated and these colors should be customizable, but I'm going to merge the PR with the current values to keep the look of these as I originally intended. We can revisit eventually, but for now I'd like to keep the default colors.
Darken outline hover color to match default button hover (#24150)
chore: sync with twbs (#1)
Remove .col-form-legend in favor of .col-form-label (#24932)
Sync v-4dev with twbs (#4)
merge after v4-beta3 release