Skip to content

inline form doc example #23452

Closed
Closed

Description

@jipexu

Hi
https://getbootstrap.com/docs/4.0/components/forms/
inline form
the provided example seems to me confusing
it's work well at smallest screen and when the space is enough to display in one line BUT on screen size who need two line we dont have y margin between form elements...

here is a code pen .. with a possible correction if necessary ?

https://codepen.io/jipexu/pen/prWMKb

Activity

  1. mattxwang commented on Aug 16, 2017

    @mattxwang

    Hey @jipexu , I tried reproducing your bug and wasn't able to replicate the issue. On my browser, each element in form-inline stacks properly with a vertical margin on a small viewport. Here's a screenshot of what I mean:

    doc

    In addition, I took a look at your codepen, and I wasn't able to find a difference between the two different examples (other than a bottom margin on the second inline form, but that exists on any viewport size).

    codepen

    Both of these screenshots were taken on Chrome Version 60.0.3112.90.

    Can you upload some screenshots of what problem you're encountering? Also, what browser are you using?

  2. added
    cssSass sources or compiled CSS
    v4v4, the frozen docs on gh-pages
    awaiting-replyWaiting on the author; an issue closes after 14 days without reply
    on Aug 16, 2017
  3. jipexu commented on Aug 16, 2017

    @jipexu
    ContributorAuthor

    @malsf21 thanks but i have this behavior on Safari, FF, and Chrome (all latest version) on Mac Sierra ?...

    it's work well at smallest screen and when the space is enough to display in one line BUT on screen size who need two line we dont have y margin between form elements....

    ??

  4. jipexu commented on Aug 16, 2017

    @jipexu
    ContributorAuthor

    form

  5. jipexu commented on Aug 16, 2017

    @jipexu
    ContributorAuthor

    doc_bs4
    foem-doc

  6. jipexu commented on Aug 16, 2017

    @jipexu
    ContributorAuthor

    i dont really said it's bug i just say the html must provide some "y" class ... and in the Doc the provided class are not (enough or correct) ...

  7. mattxwang commented on Aug 16, 2017

    @mattxwang

    Ah, I see what you're saying, that does look like a problem. If you already have a fix, you can submit a Pull Request against v4-dev. I can also help you do that if you want.

  8. jipexu commented on Aug 16, 2017

    @jipexu
    ContributorAuthor

    Thanks ! No i have no idea if we must just a PR to correct the code of the doc Or if we have to go further in css ?

  9. mattxwang commented on Aug 17, 2017

    @mattxwang

    I mean it's up to you, I'm not sure how easy (or necessary) a CSS fix even is. A PR to update the doc is probably enough for now, but you can also make a small note about the problem you faced in the docs.

  10. jipexu commented on Aug 17, 2017

    @jipexu
    ContributorAuthor

    yep probably adjust the code doc by a pr
    @mdo or team please confirm if usefull or not ?? if yes i will make pr

  11. mdo commented on Oct 2, 2017

    @mdo
    Member

    A PR would be great @jipexu.

  12. removed
    awaiting-replyWaiting on the author; an issue closes after 14 days without reply
    on Oct 2, 2017
  13. jipexu commented on Oct 23, 2017

    @jipexu
    ContributorAuthor

    @mdo oups sorry i missed this i will do it ! (because i see it's same in the new doc)

  14. added
    docsDocumentation site and its content
    on Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cssSass sources or compiled CSSdocsDocumentation site and its contenthas-prAn open pull request addresses itv4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions