Inadequate color contrast #23319

Activity

1. XhmikosR

   added

   cssSass sources or compiled CSSSass sources or compiled CSS

   docsDocumentation site and its contentDocumentation site and its content

   v4v4, the frozen docs on gh-pagesv4, the frozen docs on gh-pages

   on Aug 11, 2017
2. bardiharborow

   added

   accessibilityKeyboard, screen readers, contrast, ARIAKeyboard, screen readers, contrast, ARIA

   on Aug 11, 2017
3. patrickhlauke commented on Aug 11, 2017

   

   patrickhlauke

   on Aug 11, 2017

   Last edited by patrickhlauke

   Member

   More actions

   i tried to tackle most things relating to color contrast a while ago, but @mdo passed on most of those fixes ... hence https://getbootstrap.com/docs/4.0/getting-started/accessibility/#color-contrast

   but sure, now that many changes have landed, there's still many aspects that need to be looked at, including the markup/behavior of widgets like the carousel, tabbed dynamic navigation, accordions, popovers.
4. mdo commented on Aug 11, 2017

   

   mdo

   on Aug 11, 2017

   Member

   More actions

   Yeah, I had passed on a couple PRs because I was planning on replacing most of the existing colors outright. Didn't make sense to optimize those given that :).
5. patrickhlauke commented on Aug 11, 2017

   

   patrickhlauke

   on Aug 11, 2017

   Member

   More actions

   As said, now that it's stabilised, I'll give it another crack :)

   Also, for sanity's sake, going to keep this issue focused just on color contrast.

   👍React with 👍1Reacted by Troy Morehouse

   ❤️React with ❤️1Reacted by Mark Otto
6. patrickhlauke

   changed the title [-]Do an accessibility assessment[/-] [+]Inadequate color contrast[/+] on Aug 11, 2017
7. XhmikosR commented on Aug 11, 2017

   

   XhmikosR

   on Aug 11, 2017 via email

   MemberAuthor

   More actions

   Yup I'm mostly concerned about color issues too. Please CC me if you make a patch. On Aug 11, 2017 22:40, "Patrick H. Lauke" <notifications@github.com> wrote: As said, now that it's stabilised, I'll give it another crack :) Also, for sanity's sake, going to keep this issue focused just on color contrast. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23319 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtSrZpZTTOwY7mvRFz0ulachhFbuDks5sXK4egaJpZM4O0pmB> .
8. mdo

   added

   has-prAn open pull request addresses itAn open pull request addresses it

   on Dec 29, 2017
9. mdo

   added a commit that references this issue on Dec 29, 2017

   Darken $gray-600 by 10% for AA contrast

   ...

   This issue will close once commit 48f5408 is merged into the 'main' branch.

   48f5408
10. patrickhlauke

    closed this as completedin #25123on Dec 29, 2017
11. patrickhlauke

    added a commit that references this issue on Dec 29, 2017

    Darken $gray-600 by 10% for AA contrast (#25123)

    ...

    This issue will close once commit 625736b is merged into the 'main' branch.

    625736b
12. gijsbotje

    added a commit that references this issue on Dec 30, 2017

    merge after v4-beta3 release

    ...

    This issue will close once commit ea1c866 is merged into the 'v4-dev' branch.

    ea1c866
13. XhmikosR commented on Dec 30, 2017

    

    XhmikosR

    on Dec 30, 2017

    MemberAuthor

    More actions

    @patrickhlauke: this is not complete. The a color for example isn't adequate either.
14. patrickhlauke commented on Dec 30, 2017

    

    patrickhlauke

    on Dec 30, 2017

    Member

    More actions

    treat this #25126 as the successor, and feel free to add further examples where we fail (i made a start, but sure with the various shades and variations we use there will be more).
15. XhmikosR commented on Dec 30, 2017

    

    XhmikosR

    on Dec 30, 2017

    MemberAuthor

    More actions

    Oops, I missed that. I will have a look, thanks!