$line-height-sm/-lg is confusing #23119

Activity

1. Johann-S

   added

   cssSass sources or compiled CSSSass sources or compiled CSS

   v4v4, the frozen docs on gh-pagesv4, the frozen docs on gh-pages

   on Jul 19, 2017
2. mdo commented on Jul 19, 2017

   

   mdo

   on Jul 19, 2017

   Last edited by mdo

   Member

   More actions

   They map to small/large components, yes, but they can also be used for other things if needed. It's difficult to deal with the grid tiers and a separate scale. Unlike margin/padding, a similar scale would need to map 1:1 to the line-height value. For example: .lh-1, .lh-15 (can't do -1.5), etc. That's a little more difficult and slightly less clear.

   Thoughts from anyone else?
3. prateekgoel commented on Jul 19, 2017

   

   prateekgoel

   on Jul 19, 2017

   Last edited by prateekgoel

   Contributor

   More actions

   There are similar classes for font-size, border-radius, etc.
   I think if we are to change line-height classes, then we would also need to change such other classes for consistency which would be a big change.
4. ahmetb commented on Jul 19, 2017

   

   ahmetb

   on Jul 19, 2017

   Author

   More actions

   Yes, it looks like I was also fooled by $font-size-lg and $font-size-sm names (and others did, too #23047).
5. mdo commented on Aug 4, 2017

   

   mdo

   on Aug 4, 2017

   Member

   More actions

   Closing as a won't fix for now—this is too big of a change. We can revisit another time.
6. mdo

   closed this as completedon Aug 4, 2017