Scrollspy and active item/link

[CydGoblin]

Scrollspy adds active class to nav-link. It even says it requires Bootstrap nav component. But in the Bootstrap nav component docs mark up has active in nav-item.

Seems confusing, I tought my scrollspy was not working since mas link styling was depending on .nav-item.active and took my a while to figure it out. Shouldn't this be consistent or add a note to the docs?

[bassjobsen]

i think the active class should set on the nav-item so this is not only a docs issue.

[CydGoblin]

@iqbalaqaba I don't see how it relates... besides we are talking about v4 not v3

[wkurosawa]

I agree with @bassjobsen, seems more semantic and also resembles v3 behaviour.

[wkurosawa]

@cvrebert any thoughts on this? I could work on a PR to add class active on nav-item instead of nav-link and update tests.

[bardiharborow]

Current PRs for this issue are #17770, #18163, #20304, #20587. I'll take this and do a review when I get a chance.

[mr-july]

Any progress? Actually this is the only problem, which compels me to use custom bootstrap build. :-(

[pvdlg]

X-ref #21807