Ensure that jQuery presence check added by Grunt doesn't break AMD or CommonJS #13811

Activity

1. cvrebert

   added this to the v3.2.0 milestone on Jun 13, 2014
2. cvrebert

   added

   js

   on Jun 13, 2014
3. hnrch02 commented on Jun 13, 2014

   

   hnrch02

   on Jun 13, 2014

   Collaborator

   More actions

   I guess we can set up one example using RequireJS and one using Browserify. Where would we put those test pages though? In js/tests/umd?
   Also, we need to change the presence check to:

   if (typeof define  == 'undefined' &&
       typeof exports == 'undefined' &&
       typeof jQuery  == 'undefined') {
     throw new Error('Bootstrap\'s JavaScript requires jQuery')
   }
4. cvrebert

   added 2 commits that reference this issue on Jun 17, 2014

   address #13811

   3a4a87a

   address #13811

   f347d7d
5. cvrebert commented on Jun 22, 2014

   

   cvrebert

   on Jun 22, 2014

   CollaboratorAuthor

   More actions

   Checks fixed in #13842.
   #13843 will cover the tests.
6. cvrebert

   closed this as completedon Jun 22, 2014
7. cvrebert

   added a commit that references this issue on Jun 23, 2014

   Revert UMD (#13772 & friends) for now, due to #13812.

   ...

   c2c19a4