You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could you please be more specific about what you want? and whats wrong?
I reviewed your fiddle, and it seems like you are making mess of you code.
You have
small,
inside alert
inside heading
and you also applying text-* utility class to small?
Why would you do that?
heading small have its own color,
if you are using alert class on container, then why you would need text-danger class?
you should either use text-danger or use alert, don't use both in same context, makes no sense to me (atleast).
Also don't stuff classes in html to achieve this kind of result, instead achieve these results with css, its standard and recommended method.
As far as consider this as a bug, I don't think so,
as we can't provide flexibility and consistency both together for some elements.
It was all three
headings color, and than small colors (inside heading and such) and text-* utility classes (danger, success etc) are highly desired features, and core team tried to make them work together as much as it could be possible without sacrificing core standards, so please don't ask for too much out of core code, rather do these hacks on your on specific to your project.
There is not many projects where you would like to achieve same results, so stuffing this in core makes no sense.
Remember the more clean you keep your core (no hacks, tricks applied to core code) the more browsers, devices compatibility you will get. And it will also makes your life easier to trace the issues, as with hacks, its hard to fix the issues if they are part of core.
Framework is meant to give you just kind of roadmap, its not a final solution, so any specific changes should be done in your own custom files.
I just think that the tag "small" and class "small" should have the same color as the rest of the text inside the "div.alert" depending by type (danger/warning/primary). Now, the text inside the "small" tag is gray, even if we assign the class "text-danger".
Я понимаю что все это из за заголовка, и проблема не критична. В любом случае, тему можно закрыть.
Going to have to punt this to v4. I don't want to get into more specificity wars with ourselves for stuff like this. We'll be doing more to avoid this come v4.
Activity
saas786 commentedon Feb 20, 2014
Could you please be more specific about what you want? and whats wrong?
I reviewed your fiddle, and it seems like you are making mess of you code.
You have
small,
inside alert
inside heading
and you also applying text-* utility class to small?
Why would you do that?
heading small have its own color,
if you are using alert class on container, then why you would need text-danger class?
you should either use text-danger or use alert, don't use both in same context, makes no sense to me (atleast).
Also don't stuff classes in html to achieve this kind of result, instead achieve these results with css, its standard and recommended method.
As far as consider this as a bug, I don't think so,
as we can't provide flexibility and consistency both together for some elements.
It was all three
headings color, and than small colors (inside heading and such) and text-* utility classes (danger, success etc) are highly desired features, and core team tried to make them work together as much as it could be possible without sacrificing core standards, so please don't ask for too much out of core code, rather do these hacks on your on specific to your project.
There is not many projects where you would like to achieve same results, so stuffing this in core makes no sense.
Remember the more clean you keep your core (no hacks, tricks applied to core code) the more browsers, devices compatibility you will get. And it will also makes your life easier to trace the issues, as with hacks, its hard to fix the issues if they are part of core.
Framework is meant to give you just kind of roadmap, its not a final solution, so any specific changes should be done in your own custom files.
HardCoderNET commentedon Feb 20, 2014
I just think that the tag "small" and class "small" should have the same color as the rest of the text inside the "div.alert" depending by type (danger/warning/primary). Now, the text inside the "small" tag is gray, even if we assign the class "text-danger".
Я понимаю что все это из за заголовка, и проблема не критична. В любом случае, тему можно закрыть.
mdo commentedon Feb 24, 2014
The shitty part about this is there's no real way to go about fixing this without busting something else. We have a couple options:
!importantto our text classes, but that's just overkill as we know from utility classes.colorall together fromsmall/.smallwithin headings, and don't set it at all.coloron allsmall/.small` elements, regardless of where they appear.The only viable one is the second in my opinion. That, or we make a note of this and punt to v4. Thoughts?
mdo commentedon Mar 9, 2014
Going to have to punt this to v4. I don't want to get into more specificity wars with ourselves for stuff like this. We'll be doing more to avoid this come v4.