Skip to content

The number of columns should be an additional parameter for make-grid() and make-grid-columns-float() #11322

Closed

Description

@bassjobsen

Cause @grid-columns will be used to define the number of columns in make-grid() and make-grid-columns-float() it will be impossible to compile sub grid with different number of columns. See also: http://stackoverflow.com/a/19724075/1596547

The extra parameter will make possible to do:

make-grid(@grid-columns, sm, width,@grid-columns); and make-grid(6, sm, width,6); etc.

Activity

  1. cvrebert commented on Nov 1, 2013

    @cvrebert
    Collaborator

    This sounds pretty doable+reasonable, although I don't know how much we care about supporting/helping multiple custom grid systems in the first place.

  2. zlatanvasovic commented on Nov 1, 2013

    @zlatanvasovic

    This sounds bad. Subgrid = grid in grid (nesting). Bootstrap already has nesting support.

  3. bassjobsen commented on Nov 1, 2013

    @bassjobsen
    ContributorAuthor

    @zdroid i want to nest for example a 10 columns grid inside a 12 columns grid. This differs from the current nesting (support).

  4. zlatanvasovic commented on Nov 1, 2013

    @zlatanvasovic

    Why? Bootstrap cannot support every case.

    2013/11/1 Bass Jobsen notifications@github.com

    @zdroid https://github.com/ZDroid i want to nest for example a 10
    columns grid inside a 12 columns grid. This differs from the current
    nesting (support).

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/11322#issuecomment-27560573
    .

    Zlatan Vasović - ZDroid

  5. am80l commented on Nov 6, 2013

    @am80l

    +1

  6. mdo commented on Nov 28, 2013

    @mdo
    Member

    Multiple custom grids won't be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cssSass sources or compiled CSSfeatureNew feature, or a change to how an existing one works

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions