Bump TerminalGuiVersion to 2.4.18-develop.31 (needs fixes) - #282
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e64755b5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to build against the ../Terminal.Gui enlistment instead (see Directory.Build.targets). | ||
| --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.5</TerminalGuiVersion> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.4.18-develop.31</TerminalGuiVersion> |
There was a problem hiding this comment.
Land compatibility fixes with the dependency bump
Do not land this pin by itself: the bump-terminal-gui.yml red path created this change only after its Release build and configured test suites failed, and the commit message explicitly records that source changes are required for 2.4.18-develop.31. Because every Terminal.Gui-consuming project resolves this property, merging it unchanged makes the repository consume a dependency already known to break validation; include the compatibility fixes and passing tests or retain 2.4.18-develop.5. CLAUDE.mdL25-L25
Useful? React with 👍 / 👎.
Automated bump of
TerminalGuiVersionfrom2.4.18-develop.5to2.4.18-develop.31failed validation (build or tests).Editor needs source changes to absorb this Terminal.Gui update. See the
failed workflow run.