Repository navigation
Conversation
The models/ split dropped the loop-head capture (present at 38a5b42, src/models/lfm2.cpp:252), so any decode with embeddings_layer_inp set - i.e. serving an LFM2 target with a DFlash/DSpark drafter - aborts in llm_graph_result::set_outputs (llama-graph.cpp:1352 'layer input tensor is null') as soon as graph_reserve builds the embd-batch graph variant, e.g. on the first mtmd image chunk of a vision request. Same unconditional capture style as qwen3.cpp. Verified: LFM2.5-VL-3B + DSpark sidecar no longer crashes on image requests; text-only LFM2.5-2.6B + its released sidecar unaffected (tau ~3.8 on a math probe).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes LFM2.5-VL-3B work with a DSpark draft model.
The lfm2 graph lost its
t_layer_inpcapture in the models/ split (still there at 38a5b42, and qwen3.cpp kept its copy). Without it the server asserts on the first request whenever a drafter is attached:One line to put it back.
Testing:
Target and mmproj are public, the draft sidecar is gated on my HF, ping me for access.
Accept length on a 20-sample MMSpec probe: 3.86 (at 38a5b42), our internal fork gets ~4.1 on the same samples. Greedy output is identical with and without the drafter.
Things I hit on the way that this PR does not fix: