Skip to content

🧪 Add exhaustive tests for language_support_for_parser edge cases - #317

Open
undivisible wants to merge 2 commits into
masterfrom
testing-improvement-language-support-16728867626511643064
Open

🧪 Add exhaustive tests for language_support_for_parser edge cases#317
undivisible wants to merge 2 commits into
masterfrom
testing-improvement-language-support-16728867626511643064

Conversation

@undivisible

@undivisible undivisible commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The language_support_for_parser function lacked proper testing for negative paths and potential runtime irregularities. This patch introduces exhaustive checks traversing all_language_support() dynamically alongside extensive edge cases (whitespaces, empty string, casing, special unicode) that gracefully fail.

📊 Coverage: Validates lookup functionality for all registered parsers dynamically and robustly defends against edge case regressions where malformed string queries might be supplied.

Result: Enhanced test coverage and explicit assurance against out-of-bounds queries for language string lookups.


PR created automatically by Jules for task 16728867626511643064 started by @undivisible


Note

Low Risk
Test-only changes to language lookup assertions; no runtime or API behavior modified.

Overview
Strengthens test_language_support_for_parser in language_support.rs by replacing a few one-off negative checks with broader coverage.

After the existing "in" / "rust" smoke assertions, the test now loops over all_language_support() and asserts every entry with a parser_id resolves via language_support_for_parser to the same language string.

It also parameterizes negative cases so language_support_for_parser must return None for fake IDs, empty strings, wrong casing ("Rust", "In"), whitespace, a null byte, special characters, and non-ASCII input—with clearer panic messages per case.

Reviewed by Cursor Bugbot for commit d8212c6. Configure here.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_cc0687bd-d539-4bcb-9f52-8f6bf5527569)

@mergify

mergify Bot commented Sep 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant