⚡ Optimize Ghidra script emit with buffered StringBuilder - #312
⚡ Optimize Ghidra script emit with buffered StringBuilder#312undivisible wants to merge 1 commit into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_861cc30d-fe7f-4a92-a623-53c1f59e0f97) |
|
Tick the box to add this pull request to the merge queue (same as
|
💡 What:
Replaced immediate
System.out.println(line)calls insideGhidraDumpFuncs.emit()with aStringBuilder-based buffer. The buffer accumulates string output and flushes toSystem.out.print()in chunked intervals of 64KB, as well as a final flush in atry...finallyblock.🎯 Why:
Calling
System.out.printlnnatively triggers synchronized, blocking I/O on every iteration. Since this script emits lines in a tight loop proportional to the number of functions analyzed, it creates unnecessary I/O overhead that significantly bottlenecks headless script execution on large binaries.📊 Measured Improvement:
A focused Java microbenchmark simulating 100,000
emit()calls comparing directSystem.out.printlnversus chunkedStringBuilderbatching showed:println): ~240-250msStringBuilder): ~25-45msPR created automatically by Jules for task 17411793527089582435 started by @undivisible
Note
Low Risk
Logging-only change in a Ghidra smoke script; output format is preserved with a final flush.
Overview
Buffers Ghidra dump script stdout to cut per-line I/O during large function scans.
GhidraDumpFuncsnow accumulatesGHIDRA_*lines in aStringBuilderinstead of callingSystem.out.printlnon everyemit(). Output flushes when the buffer exceeds 64KB and again in an outerfinallyviaflushEmit(), so headless smoke logs (grep '^GHIDRA_') still get complete lines without one syscall per function.The main
run()body is wrapped intry/finallyso buffered metrics are always written even if decompilation or enumeration fails partway through.Reviewed by Cursor Bugbot for commit e661c71. Configure here.