feat(deals): add and remove people on a deal - #58
Closed
roger-guifav wants to merge 1 commit into
Closed
Conversation
The Contacts tab only showed an empty state with no write path, even though DealContact already exists. Add deals.addContact / deals.removeContact and a company-scoped picker with optional role.
|
Someone is attempting to deploy a commit to the Comp AI - PoC Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Noting for maintainers: this is a focused fix for deal people attach/detach only (issue #57). I see #56 (lewis/contact-and-currencies) is a broader PR that also mentions deal–contact management. If that lands first and covers the same gap, this PR can stay closed as a duplicate. If #56 is delayed or does not include a company-scoped picker + Deployed and verified on our self-hosted fork (crm.guifav.dev). |
Contributor
|
It includes it, should be going out soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #57.
Deal Contacts tab previously rendered only an empty state (“bring them onto the deal”) with no API or UI to attach/detach people, despite
DealContactexisting in the schema and being returned bydeals.byId.Changes
deals.addContact({ dealId, contactId, role? })upsertsdealContactdeals.removeContact({ dealId, contactId })deletes the linkTest plan
Summary by cubic
Add the ability to attach and remove people on a deal from the Contacts tab. Adds server mutations with company-scoped validation and a simple UI with an optional role field.
deals.addContact({ dealId, contactId, role? })upserts the link;deals.removeContact({ dealId, contactId })deletes it; validates the contact belongs to the deal’s company; re-attach updates role.Written for commit 4135bcf. Summary will update on new commits.