feat(agent): stop suggesting a URL that already matches the field - #120
Merged
Conversation
…ase` Updated the release workflow to ensure that all merges into the `release` branch are done via pull requests, adhering to the established ruleset. This change prevents direct pushes that could lead to untracked releases and ensures that the release process is streamlined and error-free. The workflow now automatically creates and merges a pull request from `main` to `release` when a new tag is created, improving the reliability of the deployment process.
…ts into dispatch schedule This commit deletes the BlankFactsService and its associated methods, moving the functionality to the dispatch schedule. The `sweepBlankFacts` function is now called directly within the dispatch process, ensuring that blank fields are filled automatically at regular intervals. Additionally, the API documentation has been updated to reflect these changes.
…pace normalization This commit introduces the `canonicalValue` function to standardize URL comparisons by normalizing case, whitespace, and specific host aliases. The `sameValue` function is updated to utilize `canonicalValue`, ensuring that URLs are compared as addresses rather than strings. Additionally, integration tests are added to verify the behavior of these functions, including handling trailing slashes and different URL schemes. Documentation is updated to reflect these changes in value comparison logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened automatically when
lewis/agent-backfill-fixeswas pushed.The title is written from the diff and rewritten as you push, because this is squashed onto
mainand the title becomes the commit subject and the changelog line. Retitle it yourself and it is yours — the automation stops touching it.Summary by cubic
Stops duplicate profile URL suggestions by comparing canonical values (scheme, www, trailing slash, query, and Twitter→X alias are ignored). Also runs the blank-field sweep on the dispatch tick and makes releases ship by merging
mainintoreleasevia PRs.Bug Fixes
canonicalValueinsameValueto compare URLs by address, not string.www, scheme, queries, andtwitter.com↔x.com.Refactors
sweepBlankFactsfrom the dispatch schedule; remove the internal endpoint andBlankFactsService.maintorelease, satisfying the branch ruleset so tags actually ship.Written for commit a239ad2. Summary will update on new commits.